Design comparison
Community feedback
- @EmmanuelHexerPosted almost 3 years ago
Great work overall man.
-
One tip i can give you is to wrap your grid sections in main element to avoid accessibility issues.
-
Your sections lack header tags like h1. Use h1-h6 for headings instead of divs.
Marked as helpful0@Sonu-DuttaPosted almost 3 years ago@Phalcin thank you so much for your suggestions 😊, is it responsive? I didn't get , should I use heading tags instead section or heading tags in sequence from h1 to h6 ? Can you guide me.
0@EmmanuelHexerPosted almost 3 years ago@Sonu-Dutta Yeah its responsive, but add a little margin on the bottom when its in mobile form.
I meant use only one h1 in your pages. Then h2 for others sections. If you have another child of that section which is a heading, you can use h3 for that.
Marked as helpful0@EmmanuelHexerPosted almost 3 years ago@Sonu-Dutta Also note that Every section must have a header tag.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord