Design comparison
Solution retrospective
This Challenge was pretty fun to me and I got to learn lot about css grid. please review and let me know if changes needed.
Community feedback
- @HassiaiPosted over 1 year ago
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
To center .container on the page using flexbox, add
min-height:100vh
to the body.body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0@FloraBloombluePosted over 1 year ago@Hassiai
Thankyou so much for this advice. While I have seen in many places, as you have already mentioned, not to skip heading tags. I didn't understand what to do if there is no <h1> tag, and instead there is <h2> or <h3> looking at the design. That confuses me. So what I did was , use heading according to the design given. Hence I skipped <h1> tag. Is it always necessary to add heading according to the levels , like <h1>, <h2>,...
Then in this case , I should have used <h1> tag and then reduced the font-size according to the design, so that I do not have to use <h2>, <h3>?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord