Testimonials grid created with CSS Grid and Flex {Begginer}

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Enol

  Great job! :D

  I have checked your HTML structure, a few tips from me:

  • if you want treat this challenge as a single page component then you can add h1 tag with the class sr hidden for the screen readers;
  • also you can remove style CSS from the code and transfer them to the CSS file;

  RWD:

  • add max-width to the container;
  • what do you think about tablets? you can go from one column (mobiles), then create two rows with two boxes each and the 5th box will be over the entire length of the container, finally will be the desktop design pattern. Let me know what do you think about it.

  That's it.

  Cheers :D

  1

  ---

  

  Enol Igareta•115

  @Enol-IgaretaPosted almost 4 years ago

  @SzymonRojek It is a very good idea to modify the tablets that way, I will keep it in mind, thank you very much!

  1

  

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  @Enol-Igareta

  I know that this challenge didn’t require it but it will be good idea - smooth transition between different devices. I would like to recommend using the inspector in your browser - amazing tool, don’t you think? :D

  Cheers :D

  0
• 

  David Ouma•270

  @daudi13Posted almost 4 years ago

  Hello, I've gone through your code and I've found it very well organised, responsive, clean and DRY. I've also learnt a lot from it. I did not really find any particular errors in your code. Keep it up. Happy coding.

  1

  ---

  

  Enol Igareta•115

  @Enol-IgaretaPosted almost 4 years ago

  @daudi13 Thank you very much for your support :)

  0