Skip to content
Submitted about 2 years ago

Testimonials Grid Challenge

Sarah•50
@SwankypantsSarah
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Testimonials grid section
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello @SwankypantsSarah, congratulations on your new solution!

    I’ve some suggestions for you:

    You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Sarah•50
    @SwankypantsSarahPosted about 2 years ago

    @correlucas I started to use block quote, but I noticed it indented (thinking now, it might have been before I updated margins to 0).

    Thank you for the input! I'll pay attention to that.

    0
  • バレンタイン 😈•64,190
    @VCaramesPosted about 2 years ago

    Hey there! 👋 Here are some suggestions to help improve your code:

    • To center you content to your page, add the following to your Body Element:
    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
    • The Aside Element is being used incorrectly and it is not needed for this challenge. Instead, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

    Code:

    <figure>
   <figcaption></figcaption>
   <blockquote></blockquote>
</figure>

    More Info:

    ARTICLE

    • The "bold" and "regular" testimonial are both part of the same testimonial, so they both be inside the Blockquote Element.

    • Implement a Mobile First approach 📱 > 🖥

    With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

    • Your content is not fully responsive. Here is a link to Google Developer’s site that will teach you how make it 100% responsive:

    https://web.dev/learn/design/

    If you have any questions or need further clarification, let me know.

    Happy Coding! 👻🎃

    0
  • Kristina Radosavljevic•380
    @KristinaRadosavljevicPosted about 2 years ago

    Hi, Sara! Congrats on the solution, it looks pretty nice :)

    One thing I noticed is that your .card__main might not be centered in the best way. Instead of using margins to center it, I would suggest you try to use flexbox or grid with <body> as the container and then you can use align-items and justify-content properties to center the main content both vertically and horizontally.

    And also, it might not be the best idea to use fixed width and height because then the content doesn't scale well with the user's screen. My suggestion is to use max-width instead of just width and to lose the height altogether because then the height will be adjusted to the content.

    Hope this helps and once again good job :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord