Testimonials Grid , but the grid wont wrap

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  P

  Lo-Deck•2,790

  @Lo-DeckPosted over 1 year ago

  Ok, i've tried with your website and that is my solution I don't know if it's the best but maybe help you.

  for the question 2: '''article { border-radius: 15px; padding: 2rem; box-shadow: 5px 10px 50px hsl(0, 0%, 81%); position: relative; }

  .quotes { position: absolute; z-index: 0; top: 0; left: 22rem; } '''

  and for the third i've just changed this: '''main { display: grid; padding: 0 0px; gap: 2rem; grid-template-columns: repeat(4, 1fr); grid-template-rows: auto; }'''

  padding to zero.

  and for the first I'm not sure what you want. If it's when you want to reduce the page or to turn into web mobile , uses the media queries.

  Last thing the only YTchannel I know in English is slayingthedragon it was helpful for me Youtube slayingthedragon

  Marked as helpful

  1
• 

  00013519•110

  @00013519Posted over 1 year ago

  To the second question: I have put it as background image inside the daniel clifford section, and set the background-position-x value to 90%, so it is not going to the left completely

  Marked as helpful

  1
• 

  P

  Lo-Deck•2,790

  @Lo-DeckPosted over 1 year ago

  Hi, for the 'position : absolute', you need to declare 'position: relative' in the article where you want to use it. Otherwise the 'position : absolute' uses the farthest ancestor.

  mozilla mdn.

  Hope to be useful.

  Marked as helpful

  1