Design comparison
Solution retrospective
Hello everyone! I'm glad to finally post my first solution here and share it with you! My question is, how can I improve the responsiveness of my website? I used flexbox and it isn't working correctly. Could you help me to know what I did wrong in my css?? Thank you for all the information you could provide! Happy coding ;d
Community feedback
- @RenszCamachoPosted almost 4 years ago
@guilhermek1 Oh cool. I'm a learner too. So we're on the same boat.
About your code. I see that you got many div, you could have an article tag in every card component, and in the container, have the main tag. for example.
Also, you got more than one h1 tag. I suggested you for good practices, only have one h1 tag.
If you have more than one set of h1 tags, you’re sending a less clear message to Google, and by having more than one important heading on the page, you’re making your human readers’ experience less clear as well.
For those reasons, I’d stick to one h1 tag if you can.
Newbie opinion. I hope it helps.
Havo good day.
4@SzymonRojekPosted almost 4 years ago@RenszCamacho
Exactly, using multiple H1 tags depends on what HTML version you are using. If it's HTML4 or XHTML, only use one H1 per page, but if you are using HTML5 you can have one per section and you will not get an error.
The main conclusion is that we should use one h1 per page or view. H1 => it should concisely describe the overall purpose of the content. Using more than one per page it is not considered a best practice and may subvert the expectations of how screen reader users navigate.
Cheers :D
2 - @RenszCamachoPosted almost 4 years ago
Hello Mate.
Just I few suggestions in my humble newbie opinion. 😊
I would use css-grid for this challenge. I reckon that helps a lot in this type of layout. If you haven't heard about that. You can check this site
A few media queries. and done.
Hopefully, it helps. Happy coding🧑💻
2@guilhermek1Posted almost 4 years agoI'm currently learning about grids. I didn't use it on this solution because I didn't feel confident enough to use it yet. On the other hand, I felt that I could do this challenge using only flexbox. However, I'll try get the same result using grid! Besides that, what did you think about my code, is there something else that you see that I could improve?? Thank you for your help and feedback! @RenszCamacho
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord