Design comparison
Solution retrospective
I really like css grid...
Community feedback
- @correlucasPosted about 2 years ago
πΎHello again Ben , congratulations for your new solution!
Great solution and great code, nice work putting everything together and making the html structure neat. You've used a lot of semantic html markup to wrap the content and this is nice, you can wrap the paragraph with the quote with the tag
<blockquote>
this way you'll wrap each block of element with the best tag in this situation.You have also a little issue with the vertical alignment that can be solved using
min-height: 100vh
and flexbox aim the body, and removing the margins.π I hope this helps you and happy coding!
Marked as helpful1 - @AdrianoEscarabotePosted about 2 years ago
Hi @BenScattergood, how are you?
I really liked the result of this project, but I have some tips that I think you will like:
1- Heading levels should only increase by one click here
2- I noticed that the layout was stretching a lot at lower resolutions, to fix this I made the following change in the code:
body { margin: 0 auto; max-width: 1440px; }
I used the margin to center the content!
The rest is basically perfect, congratulations on the result!
Hope it helps... π
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord