Design comparison
Solution retrospective
Using CSS GRID I'm always using Flexbox so I wasn't paying attention to Grid but with this project i learned flex grid deeply .
What challenges did you encounter, and how did you overcome them?The challenge to convert my desktop grid into media query grid with the correct position of my element
What specific areas of your project would you like help with?None
Community feedback
- @oppaheroPosted 7 months ago
Hi!
Congratulations on finishing this challenge✨
I have a suggestion about your code that might interest you 💡
📍 In the card, if you give a fixed width to the title ("item__description__1"), this can't adjust himself to the container. So, in mobile screen the text is overflow
To avoid this, don't give a width to it ("item__description__1"), and just let it adjust his width according to his container
📍 Group styles that are the same, as in the case of images.
Instead of applying the same rules to each image class (item__picture__1 ... item__picture__5), you can indicate them directly in the img tag
img { border-radius: 50%; width: 40px; height: 40px; }
This way you have cleaner and easier to maintain code.
📍 Take a look at BEM notation, to better name your classes
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord