María López• 240
@oppahero
Posted
Hi!
Congratulations on finishing this challenge✨
I have a suggestion about your code that might interest you 💡
📍 In the card, if you give a fixed width to the title ("item__description__1"), this can't adjust himself to the container. So, in mobile screen the text is overflow
To avoid this, don't give a width to it ("item__description__1"), and just let it adjust his width according to his container
📍 Group styles that are the same, as in the case of images.
Instead of applying the same rules to each image class (item__picture__1 ... item__picture__5), you can indicate them directly in the img tag
img {
border-radius: 50%;
width: 40px;
height: 40px;
}
This way you have cleaner and easier to maintain code.
📍 Take a look at BEM notation, to better name your classes
Happy coding!
0
