Testimonial-grid-Frontend-mentor-challenge-Solution

Community feedback

• 

  RabbitMaid•1,020

  @AgbortokoPosted over 1 year ago

  HTML5 elements such as <main>, <nav>, <header>, <footer>, <section>, <aside> act as landmarks, or special regions on the page to which screen readers and other assistive technologies can jump. By using landmark elements, you can dramatically improve the navigation experience on your site for users of assistive technology (Users with disabilities) .

  You can use the <div> for sub items within landmarks like <section>. In other words for containers or sections in your html you can use the <section> tag.

  You did great! Just some few amelioration needed for it to be perfect.

  Marked as helpful

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="testimonial-grid-container"> with the main tag, <div class="attribution"> with the footer tag and the html must have <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .testimonial-grid-container on the page using flexbox or grid instead of a margin and padding, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  Use relative units like rem or em as unit for the padding, margin and width values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0