Testimonial-Grid-Challenge

Community feedback

• 

  Shchetkov Maksim•470

  @ArmsAndArrowsPosted over 1 year ago

  Hi. Great work! It's a quite accurate implementation.

  I can suggest you to start building grids by mobile first step - it's much easier to reassign grid properties with media queries as the size keeps growing. Also it's great to avoid using pixels except really small things like borders.

  And I checked code on github it seems like at line 127 of css file you started writing responsive queries, but you didn't close whole query at the end with a curly bracket.

  I hope these suggestions would help you a little at your professional career =)

  Marked as helpful

  1

  ---

  

  Dumte Nwidoobee Joshua•100

  @DumtePosted over 1 year ago

  @ArmsAndArrows when they say the width should be 1440px, are they talking about the with of the body of the width of the container div?

  0

  

  Shchetkov Maksim•470

  @ArmsAndArrowsPosted over 1 year ago

  @Dumte It means "at viewport width of 1440px". They attached in design folder picture called design-desktop with exact same size. Also they attached mobile-design with size for mobile 375. As a great reference you can use google chrome extension called "perfect pixel", then open responsive mode in browser and attach this picture.

  1

  

  Dumte Nwidoobee Joshua•100

  @DumtePosted over 1 year ago

  Please can you connect with me on Twitter so we can discuss in detail. I need your help @ArmsAndArrows

  0

  

  Shchetkov Maksim•470

  @ArmsAndArrowsPosted over 1 year ago

  @Dumte sorry, I don't have twitter yet, as soon as I'll create an account I'll let you know =)

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution lacks usage of <h1> so it can cause severe accessibility errors due to lack of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">Testimonials grid section</h1>

  ---

  • If you have any questions or need further clarification, you can always check out my submission for another challenge where i used this technique and feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0