Testimonial-Grid

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  body {
  min-height: 100vh;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Khawar Mehfooz•530

  @KhawarmehfoozPosted over 1 year ago

  Hi! 👋 Congratulations on completing the challenge!

  I have some suggestions to improve the solution:

  • Add the following CSS properties to the body to properly center the main-container:

  height:100vh;
  display:grid;
  place-items:center;
  

  • Add the following CSS properties to the main-container to properly resize the container:

  width: min(75%, 70rem);
  

  Happy coding!

  Marked as helpful

  0