Testimonial section challenge, build with HTML,CSS,Sass

Community feedback

• 

  P

  Kamran Kiani•2,740

  @kaamiikPosted about 1 month ago

  Hi. Some notes for your code:

  • In each .testimonial, The person name can be a h2 tag as a heding.

  ---

  • Also you have two blockquote. So you can structure like this:

    <blockquote>
      <p>Bold text</p>
      <p>Regular text</p>
    </blockquote> 
    

    And for your css you can add this too:

    blockquote > p.regular::before {
      content: "" ";
    }
    blockquote > p.regular::after {
      content: " "";
    }
    

    This CSS does not allow the " select when you wanna select the text with your mouse.

  ---

  • Profile images do not need alt text. You can set it to alt="". Avoid using words like image, picture, or photo in alt descriptions.

  ---

  • For your CSS, There is lots of files and honestly It's really hard for me to find the problems. I think If you are using vanilla CSS It's better to wrap all of your code in one file or two file.

  ---

  • Generally from your preview I can say you only need a max-width on your section tag. You do not need min-width. And for your grid, You only need four columns and two rows and there is no need to define the rows height in your code. It's not true. Take this very simple and do not over complicate the code for your self.

  Marked as helpful

  0

  ---

  

  P

  VirginiaPatrika•130

  @VirginiaPatPosted about 1 month ago

  @kaamiik Thank you very much for your feedback! It was very helpful. I decided to rebuild the layout again using sass for the first time. I found the process faster and easier. It seems the outcome is closer to what it should be. If you have time to check it, I would love to hear you feedback.

  0

  

  P

  Kamran Kiani•2,740

  @kaamiikPosted about 1 month ago

  @VirginiaPat It's much better now. Congratulation!

  I think you can remove min-width and you don't need it. Also the ::before and ::after is not working for adding the quote because you use the testimonial__text__medium class instead of text__medium.

  But overall you did a great job. I suggest now you watch the Kevin Powell that did this challenge in another way too. It really helps. https://www.youtube.com/watch?v=rg7Fvvl3taU

  Marked as helpful

  0
• 

  P

  Antônio Alves Cataldo•120

  @TonyzCataldoPosted about 1 month ago

  Well, your design size is bigger than the request desktop design, outherwise your design is fine. keep coding.

  0