Testimonial Page using CSS Grid

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @RonenTGreat, great job on this project!

  Some suggestions to improve you code:

  • For accessibility purposes, it’s best to use rem/em instead of px for your CSS property values.

  • For the quotes themselves, its semantically better to use the <blockquote> element. The <blockquote> HTML element indicates that the enclosed text is an extended quotation. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote

  • To make it easier to deal with CSS , have more control over your content, and want to ensure that everything will look the same regardless of browser used I suggest taking a look at CSS Resets.

  CSS Resets are customizable for your preference.

  Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  Happy Coding!

  Marked as helpful

  1

  ---

  

  Ronen Hammond•260

  @RonenTGreatPosted about 2 years ago

  Thank you for the suggestion @vcarames

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @RonenTGreat, Congratulations on completing this challenge!

  Great code and great solution! I did this challenge too and know how hard it is to set up this grid layout. I think you've done a really good job building everything! Here are some tips for you:

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  To reduce your CSS file and improve the performance of loading your page you can use a tool called CSS minify that reduces the CSS code by removing the unnecessary characters. You can use a VSCode plugin called minify css or this website tool to reduce your code: https://www.toptal.com/developers/cssminifier

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  Ronen Hammond•260

  @RonenTGreatPosted about 2 years ago

  Thank you @correlucas, I appreciate the insight. I will work on my HTML semantics more.

  0