Design comparison
Solution retrospective
This is the first time I've really played around with grid. Any feedback on how I could use it better would be greatly appreciated :)
Community feedback
- @sulemaan7070Posted over 1 year ago
hey Danton Rutheπ, great job on completing the challenge here are a few tips to make your site design accurate...
1.You can add shadow to the
.testimonials
section.2.Though you seem to have added the images there are visible on the site..and must give any name to the alt="" attribute of the
img
.3.change the
.app
container div.. tomain
.Everything else looks great !! Hope that helps happy codingπ₯ππ»π―
Marked as helpful1 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div id="app">
with semantic element<main>
and<div class="attribution">
with element<footer>
to improve accessibility and organization of your page.
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord