RESPONSIVE TESTIMONIAL PAGE USING CSS GRID

Community feedback

• 

  Renszo Camacho•1,615

  @RenszCamachoPosted almost 4 years ago

  Hi 👋🏻 Afolabi Oseni. Well done my friend 👏👏👏. You have done a fantastic job on this challenge 👌, I noticed that you did mobile-first, and it’s quite responsive 💯.

  Just I few suggestions in my humble newbie opinion. 😊

  -It'd be great if you just use classes in your CSS file and the IDs place it in Js file.

  -Your div#wrapper isn't centered on the large screen.

  I would fix that with the media queries. @media (min-width: 1440px){margin: 14em auto; or another way is using flex-box and forget the media queries.

  🚀Nice solution!!!! Keep coding🧑‍💻

  1

  ---

  

  Afolabi Oseni•105

  @GoldenAceTechPosted almost 4 years ago

  @RenszCamacho thank you for the feedback my man, when you said it is not centered, do you mean vertically or horizontally? Also I like to use IDs for elements that only appear once on the page or maybe they wouldn't have the same style as any other element on the page. I use classes for elements that are styled the same. It helps identify similar elements that have common styles and makes my work easier to read and debug.

  1

  

  Renszo Camacho•1,615

  @RenszCamachoPosted almost 4 years ago

  @GoldenAceTech Ok, Now I understand why you use the Ids. Cool! And what I mean horizontally, is oriented towards the top. My laptop looks good. But On my desktop, not.

  Have a nice one my friend.

  1