@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
Metadata ποΈ:
- Add a title of the page. The
<title>
tag is used to specify the title of a web page, which is displayed in the browser's title bar or tab, and is also used by search engines as the title of a page in search results.
HTML π·οΈ:
- Wrap the page's whole main content in the
<main>
tag.
- You shouldn't use heading elements for every element in your solution, you should try to better organize the heading structure. You can read more about this https://www.a11yproject.com/posts/how-to-accessible-heading-structure/
-
The image with the testimonial author is not a decoration, you need to provide an alternative text to tell the user who is the author of the testimonial, its recommended to use the author's name as the
alt
attribute value. e.g.alt="Daniel Clifford"
If you want to learn more about the
alt
attribute, you can read this article. π.
-
To improve the semantics of your code you should use the
<figure>
and<blockquote>
tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.Example:
<figure> <blockquote> <p>"Example of a testimonial"</p> </blockquote> <figcaption> <p>Example of the author</p> </figcaption> </figure>
You can read more about the
<figure>
and<blockquote>
tags with this two links:
I hope you find it useful! π
Happy coding!
Marked as helpful