Testimonial grid whit responsive mobile

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. The layout is missing the background-color, you might want to fix that. The layout in general is good in desktop, the mobile as well is good. But the scaling, I think you could do more about the layout, since you are using grid right, instead of just making the desktop and mobile layout from the design, you could had added a custom layout, like a 2x2 grid, or different, just to showcase that grid skill right.

  Also, if you are talking about the font-sizes, that's fine, on a real project, I would make the text more larger to make it more readable.

  Some suggestions would be:

  • It is great that you added h1 on this, but it does not do anything at the moment. You should have added a text inside it like frontendmentor grid testimonial example. The h1 also should have sr-only class. You can google that class, that is a class that is intended for screen reader users, making it accessible.
  • Each testimonial could have been wrapped inside blockquote.
  • The alt of the images of each person should have their name as the value, like alt="Daniel Clifford".
  • The name of the person, as well as their position, should be wrapped inside a heading tag like h2 or h3. The reason is that, since it is a testimonial, it would be wise to make their name heading tag, so that user can navigate in a heading tag properly, and if they encounter it, they would know that the next text will be their testimonial.
  • The highlighted text of their testimonial should use p tag. Text element needs to be inside p tag.

  Other than those, great work.

  Marked as helpful

  1

  ---

  

  Johnnatan•305

  @JohnnatanVPosted about 3 years ago

  @pikamart thanks fot the tips i Will work on that as soon as i can, this is the feedback i need to improve thank you very much.

  0