@AdrianoEscarabote
Posted
Hi Alexander, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:
You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.
h1, h2, p, span {
font-size: 13px;
}
avoid using px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: [px to rem](https://marketplace.visualstudio.com/items?itemName=sainoba.px-to -rem)
The rest is great!
I hope it helps... 👍
Marked as helpful
@Perr0fe0
Posted
@AdrianoEscarabote Hi there!.
I didn't know that the <br> tag could cause these problems, I'll keep it in mind..
I also know that it's better to use rem unit, I just wanted to see how it would look with px hahahaha.
I use the px to rem converter a lot in my projects.
thanks so much for you feedback!.