Design comparison
SolutionDesign
Community feedback
- @iprinceroyyPosted over 2 years ago
That's excellent work @zach007james. You need to focus on some key points here:-
- There should be one heading tag on a web page, if there is no heading element requirement, then set its font size to 0.
HTML- <h1></h1> CSS- h1{ font-size: 0; }
- The content should be wrapped inside the main landmark to avoid accessibility issues. Like this
<body><main>your content goes here......</main></body>
. - There must be only one header element, here you should replace multiple header elements with div or section.
- There is no need for srcset attribute in the img tag.
All the others are perfect. Hope it adds to your learning, Happy Coding :)
Marked as helpful0@zach007jamesPosted over 2 years agoThank you for your feedback @iprinceroyy ! I will remember to format my HTML better with correct <header>, <main>, and <footer> tags - only using these ones once and using <div> and <section> otherwise. Thank you for the heading tip... I had no idea you should only use one for accessibility.
Thank you for taking the time to help. Your assistance is greatly appreciated!
1 - There should be one heading tag on a web page, if there is no heading element requirement, then set its font size to 0.
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord