Testimonial Grid [+Tablet Design - BEM - Mobile First - Vanilla CSS]

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 1 year ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The only headings ⚠️ in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph element.

  • The profile images alt tags need to be improved ⚠️. It should ALWAYS and only state the person’s full name.

  • Remove all the br elements you added; they are being used incorrectly ⚠️.

  • The article element is not the best choice ❌ for wrapping these testimonials. In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  More Info:📚

  MDN Article Element

  • For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • Level 4 media queries are not fully supported ⚠️, so you component is stuck in mobile layout.

  More Info:📚 MDN Media Queries

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  0

  ---

  

  P

  DeyanTopalov•430

  @DeyanTopalovPosted about 1 year ago

  @vcarames

  Hi, and thanks a million for the feedback!

  Quick question on my end:

  Quote

  • Level 4 media queries are not fully supported ⚠️, so you component is stuck in mobile layout.

  Can you labored on that? Based on what I see, it is supported in the recent browser versions & also I have previewed the solution in Chrome, Firefox, Edge & Safari and it works as intended.

  P.s I am already working on the other fixes that you suggested, and your feedback is much appreciated!

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 1 year ago

  @DeyanTopalov

  I'll send you a screenshot of how your content looks like, in the Discord channel.

  0