
Testimonial grid system with html, css and a library
Design comparison
Community feedback
- P@jayco01Posted about 2 months ago
Hey! Your project looks great, and I can see you’ve put in a lot of effort. Here are a few friendly suggestions:
-
Simplify Your CSS Structure Your CSS does a great job at making the layout responsive, but there are quite a few repeated styles, especially in defining column layouts (.c-1, .c-2, .m-1, .m-2, .l-1, .l-2). Instead of defining each width manually, using CSS Grid or Flexbox could help simplify things. This would make your code more efficient and easier to maintain!
-
Make Class Names More Descriptive Some of your class names could be a bit clearer. For example, testimonial__img could be renamed to testimonial__quotation-mark so it's immediately clear what it represents. Small tweaks like this can make your code more readable at a glance!
-
Adjust the Quotation Mark Image for Different Screens I noticed the quotation mark image appears on both mobile and desktop, but it’s only supposed to be visible on larger screens. Instead of using display: none;, you could make sure it only appears in larger screen sizes with a media query. That way, the design stays true to the challenge!
Hope this helps!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord