Testimonial grid session using CSS GRID
Design comparison
Solution retrospective
Hey mentors and friends,
I tried to get better with every new challenge and I will be glad to hear your feedback on this.
CSS position is giving me a tough time, please kindly recommend a good video or resources that can help me grasp the concept of position.
Thank you all and don't forget the feedback. I really need it for my growth.
Happy coding!
Community feedback
- @grace-snowPosted almost 4 years ago
Hi Iyanu
A few validation issues on your html at the moment but easy to fix. You can only have one h1 per page and all headings have to go in order. Think of it like a normal document. The headings and then subheadings define the structure of your document. Same with html ☺
I had a look at your css and can't understand why you're using position properties on this at all? This is a good article that explains how the different values work https://css-tricks.com/almanac/properties/p/position
Hope thats helpful!
0@enigmirePosted almost 4 years ago@grace-snow Thank you so much grace.
I used position properties just to position the whole design in the centre of the page since adding margins doesn't seem to work.
Thanks always for your feedback
0@grace-snowPosted almost 4 years ago@i-codde try making the whole container display flex with align items and justify content center. That's assuming the container is a block min height 100vh
Margin auto on the sides will only center horizontally.
0@enigmirePosted almost 4 years ago@grace-snow
Oh, thank you.
I will try that out and hope to get the same result as the design
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord