Testimonial Grid Section with HTML & SASS

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Didin,

  Well done :D

  I have checked your HTML and have a few tips for you:

  • you have used so many divs => ok, that's good but they are semantically inert elements — elements that don’t do or say anything, of course, they are important too but you can change a bit the HTML structure by adding semantic tags => have a check MDN documentation;
  • alt text should contain a text in this challenge (check information about it, the site stack overflow will be great);
  • you didn't use any heading (generally please read about headings h1-h6) but here we have a good occasion to do it;
  • please remove styles from HTML and transfer them to the CSS file;

  CSS:

  • please reset the styles CSS;
  • add max-width: 1440px;
  • you can centre all content in the body by using grid and remove the scroll (for example overflow:hidden).

  I like your RWD. Done very well! Please, don't forget to upvote any comments on here that you find helpful. That's it from me. Hopefully, it will help you.

  Greetings :D

  1

  ---

  

  Didin•50

  @hafizhudinPosted almost 4 years ago

  @SzymonRojek Thank you very much for your feedback. Your feedback helps me a lot.

  0
• 

  Fernando Sánchez•60

  @miguelsan97Posted almost 4 years ago

  Good job and looks great, but you had to center that container. Out side that, congratulations!

  1

  ---

  

  Didin•50

  @hafizhudinPosted almost 4 years ago

  @miguelsan97 okay thank u for ur feedback bro :))

  0