Testimonial grid section with CSS-grid SCSS

Community feedback

• 

  Marlon Passos•940

  @MarlonPassos-gitPosted about 3 years ago

  hey I really liked your project, the way you left the content for 3 columns was really cool, but be sad because I thought there would be a 2 column version too ☹ haha. The html is really cool, I had never thought of using <figcaption>, it really makes sense

  Another thing I would recommend doing is adding a distance to the top so that the first card is not stuck to the top, (add a margin or padding resolves), see https://prnt.sc/1tqlddg

  I would put the H2 in the card title and the h3 in the person's name

  0

  ---

  

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  @MarlonPassos-git Once i decided to add 2 column version but I think its good to not add that one because it was confusing me do decide layout for 2 column xD.

  Thanks for pointing out the bug, I think I am very much relying on justify-content and align-content. should need to put margin or padding as a fallback,

  Firstly I put h2 in card title and h3 in the person's name, but the report was giving me the error of headings level so i switched it haha. This was the last version of my report which points the error.

  Thanks for your feedback..

  keep coding :)

  1