Abhik• 4,840
@abhik-b
Posted
Hi Muhammad 👋
Good job on this challenge , like @Antoine-Flo said try to avoid using a fix height for the grid row for the mobile layout and try to have some hover states other than that great work.
Keep it up 💯
1
Design comparison
Solution retrospective
Please give me feedback
Community feedback
Antoine• 220
@Antoine-Flo
Posted
Hi Muhammad ! 👋
Great job, it looks really nice ! If I had a suggestion, try to avoid using a fix height for the grid raw for the mobile layout. From your breakpoint at 940px, because of the fixed height there is a huge empty space in the Daniel Clifford card.
And I'm not sure you have to specify grid-column: auto; grid-row: auto; at the end of your css, it should be the default behavior (but maybe I'm mistaken).
Anyway nice job again 👍
1
@hassanahmadp
Posted
Thanks a lot for your kind suggestion Antonio. You have given me the right advise, I will work on it.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord