Testimonial grid section using css grid

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  ezecoder•870

  @3eze3Posted over 1 year ago

  Hey hello, first of all, very good solution for this challenge.

  I have some recommendations regarding your html:

  • Currently, there is only one h4 on the page. It is better to use h1 for the main title and then use secondary headings (h2, h3, etc.) as needed.

  • You could use semantic tags, such as main, or work with sections, as well as adding aria-label or aria-labelledby attributes to provide more information to screen reader users.

  • Regarding this:<h4>I received a job offer mid-course, and the subjects I learned were current, if not more so, in the company I joined. I honestly feel I got every penny's worth</h4>, the use of a p tag, or a tag (blockquote-q) would be better than a h4

  • As for the css, you could group the elements with common classes to avoid the nesting of several classes and elements, and not have problems with the specificity in a future, you could apply some methodology as BEM, which is the most common, and very practical.

  If you are interested, I leave you the page for the methodology BEM

  Marked as helpful

  0