Design comparison
Solution retrospective
- Added dark theme to this project.
Community feedback
- @correlucasPosted about 2 years ago
👾Hi Krutagna Patel, congrats on completing this challenge!
You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the
quote text
you can improve the accessibility there using<blockquote>
to indicate to screen readers that the content inside that paragraph is a quote.✌️ I hope this helps you and happy coding!
Marked as helpful1@krutagna10Posted about 2 years ago@correlucas Okay, thank you very much for the suggestion , I will keep that in mind in my future projects.
1 - @vanzasetiaPosted about 2 years ago
Hello, Krutagna Patel! 👋
One recommendation I have is to not change the
html
(or the:root
)font-size
can cause huge accessibility implications for those users with different font sizes or zoom requirements. I recommend taking a look at these resources to learn more about the issues.- A blog post by Josh Comeau where he writes about the problem of the 62.5% trick (and more!).
- A comment from an accessibility expert (Grace Snow) about it.
Hope this helps!
Marked as helpful1@krutagna10Posted about 2 years ago@vanzasetia Okay, I will keep that in mind when I am doing my future projects
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord