Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
In this challenge, I started to learn more about grid function, and it's not as hard as I thought 🎉
What challenges did you encounter, and how did you overcome them?Still working on the mobile version.
Community feedback
- @DrakeHermitPosted 7 months ago
Your solution is but the cards are a bit too big compared to the design, but that's not a problem at all.
Make sure to finish the mobile version of the design too, maybe going with mobile first approach for this challenge wouldn't be a bad thing.
But other than that your code seems good, but there are few things I would change.
- Don't put your resets on
html
selector - I would have a
<main></main>
tag as the container for the whole thing - Don't use
<div>
to display text, use the paragraph<p>
tag font-family
,font-size
, andbackground-color
usually go on thebody {}
selector- Make use of CSS variables since they help out a ton, here's a link that explains CSS Variables
Marked as helpful0@yudixaPosted 5 months ago@DrakeHermit Thank you for your comment. As a beginner, your input is valuable to me. Appreciate it.
1 - Don't put your resets on
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord