Design comparison
Community feedback
- @correlucasPosted about 2 years ago
๐พHello @Mahmoudelhousiny, congratulations on your new solution!
Great code and great solution! I did this challenge too and know how hard it is to set up this
grid layout
. I think you've done a really good job building everything! Here are some tips for you:1.You've missed the color for the background, in this case is
background-color: #EDF2F8
and add it to the body.2.Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with
<main>
or section, about the cards you can replace the<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Note that<div>
is only a block element without meaning, prefer to use it for small blocks of content.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
โ๏ธ I hope this helps you and happy coding!
Marked as helpful0 - @MahmoudelhousinyPosted about 2 years ago
Thank you very much sir .. as usual i promise you to do the best next time
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord