Design comparison
Solution retrospective
Any feedback would be welcome ~
Community feedback
- @grace-snowPosted almost 4 years ago
Really nice solution. I perticularly like the way you've used the data attributes to position your cards in sass, and good use of BEM.
Only really tiny things I would change would be to
- give each card a h tag for some structure
- remove the unused card footer divs
- rename the media query mixin to make clearer what it is and that its a max width one (I'd probably name it media-down so you know if it's media-down tablet it's a media query targeting below tablet size)
- preconnect and load font via the link tag in html (more performant)
Like I said though, small personal preference things really. Well done on this, keep it up 👍
1@axevldkPosted almost 4 years ago@grace-snow, Thank you for your valuable advice 😊
0 - @pijeismartPosted almost 4 years ago
Very professional front-end skill. I guess you have been working in this field for at least 5 years. I found that class name is very readable and style is optimized.
0 - @MasterDev333Posted almost 4 years ago
Great work! Fully responsive and very close to design. Also, your code is neat and clean. Perfect! Happy coding :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord