Design comparison
Solution retrospective
Any Feedback Appreciated
Community feedback
- @correlucasPosted about 2 years ago
👾Hi Marco Louis, congrats on completing this challenge!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
1.You need to fix the
container size
that is a bit off, this challenge uses the standard container size that ismax-width: 1110px
.2.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the
quote text
you can improve the accessibility there using<blockquote>
to indicate to screen readers that the content inside that paragraph is a quote.✌️ I hope this helps you and happy coding!
Marked as helpful0 - @AdrianoEscarabotePosted about 2 years ago
Hello Marco Louis M Narca, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Page should contain a level-one heading click here
I noticed that the content is not centered to fix this we can do the following:
removed:
.container { /* margin: 0 auto; */ /* padding: 6rem 2rem; */ }
I added:
body { display: flex; align-items: center; justify-content: center; min height: 100vh; }
This also fixed the issue that the layout had at higher resolutions, it was too stretched!
Do the test!
The rest is great!!
Hope it helps...👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord