Design comparison
SolutionDesign
Solution retrospective
Any feedback on how to improve/optimize and add things to conform to good practices will be appreciated.
Community feedback
- @RioCantrePosted almost 3 years ago
Hello there! Awesome job with this one. You did well on implementing the design. I think you should considered the following as well...
- Adjust the position of top margin of
#bg-image
intomargin-top: -175px;
- Instead of using
articles
usep
- The
section
tag needs to be followed with the heading hierarchy, better usediv
orarticle
- Use only relevant values
<link rel="stylesheet" type="text/css" href="style.css" media="screen">
and clean the whitespaces
Hope this helps and Keep it up! Cheers!
Marked as helpful1 - Adjust the position of top margin of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord