Design comparison
Solution retrospective
I just finished this challenge and would really love feedbacks on how i can improve. Thanks.
Community feedback
- @RenszCamachoPosted almost 4 years ago
Hiya ππ» Nwobodo Igwe. Well done my friend πππ. You have done a fantastic job on this challenge π,I noticed that you did mobile-first, and itβs responsive π―.
Just I few issues in my humble newbie opinion. π
The purple card. Itβs not very aligned.
How Iβd do it:
- .container `grid-gap: 20px ` - .container `margin: 50px 0` - .container `padding 20px` - .grid `with: 100%` rather than 90%.
I see you very active in the community.π
4@Igwe0001Posted almost 4 years ago@RenszCamacho Hi thanks for your input, it really helped me align the cards correctly.
0 - @grace-snowPosted almost 4 years ago
Hi
If you set your mobile grid rows to all be auto you wouldn't have space at the bottom of some of them.
Hope that helps βΊ
2 - @ApplePieGiraffePosted almost 4 years ago
Hello there, Nwobodo Igwe! π
Good work on this challenge! π
In addition to centering the grid (as RenszCamacho helpfully suggested), I suggest switching to a tablet or mobile-friendly layout a little sooner than 900px to prevent a horizontal scroll bar from appearing along the bottom of the screen. π
Keep coding (and happy coding, too)! π
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord