Design comparison
Solution retrospective
Hello, this is my final solution of this challenge. Everyone is welcome to comment!
Community feedback
- @LotusElizePosted over 1 year ago
If possible, a few suggestions 0 - )
It's not a good idea to apply a border-radius of 50% to all the images on the page. This will give a rounded shape to all the images, which may not be the desired outcome. It would be better to selectively apply the border-radius using pseudo-classes or classes to specific images.
Using pseudo-classes or classes to target specific images would be a more accurate and appropriate approach.
Good practice is to use styling based on classes instead of IDs whenever possible.
Here are a few reasons why it's better to avoid extensive use of styling based on IDs:
1.Uniqueness: IDs should be unique on a page, so using them for styling limits your ability to reuse styles on other elements.
2.Specificity: Styling based on IDs has a high level of specificity, which can make managing styles and dealing with conflicts more complex, especially in larger and more complex projects.
3.Refactoring: If you change the ID of an element in the HTML, you would also need to update the styles associated with that ID. This can create extra work and potential errors.
Instead, it is recommended to use styling based on classes, as they allow for more flexibility and reusability. Classes can be applied to multiple elements, making the code modular and easier to manage.
It's important to note that there are situations where using IDs makes sense, such as for internal anchor links on a page. However, in general, it's better to avoid extensive styling based on IDs and use classes for styling elements.
Thank you, and have a great day!!)
Marked as helpful0@out0fSpac3Posted over 1 year agoThanks for the advice, somehow I missed that... However, now it's updated :) As I''m just starting here it's hard to remember every detail, but trying to do my best. @LotusElize
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord