P
Thomas Dimnet• 250
@tdimnet
Posted
Hi @KahSR,
Great work with your project! Your design looks particulary sharp on different screen sizes. It looks perfect on my 4k monitor :).
Here are some feedbacks if you want to improve your code:
- I noticed you use BEM when designing your layout. This is great but I think you could improve some of it. Here is an example:
card__username card__username--color. I think the name of this modifier could be improve. You could for example specify the color or the kind of color. For example,card__username--primaryorcard__username--secondary. BEM is great but it can be tedious sometimes ^^. - Be aware of your namming conventions. For example,
grid_card5: is it a element or a block? Most of the time with CSS, we tend to use kebab-case.
I know that these are just tinny details and I am sorry for that. The thing is your project is really good 🙂.
Have a nice day, Tom.
Marked as helpful
0
KahSR• 170
@KahSR
Posted
Hi @tdimnet
I was very happy for your feedback
I adjusted the points you suggested, they are small details but they make a difference. Sometimes I get lost in how to name using BEM 😅
Thank you very much for the comment! 😊
0
