Design comparison
Community feedback
- @AdrianoEscarabotePosted about 1 month ago
Hi danny101, hope you're doing well! I loved how your project turned out, but I’ve got a few suggestions that could be useful:
Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.
<h1>Welcome to Testimonials grid section</h1>
Consider using
rem
for font sizes. When font sizes are set in absolute units like pixels, users can't adjust the text size based on their preferences. Relative units likerem
adapt to the screen size and user settings, making them more flexible across various devices.If you'd rather keep using
px
, you can download a handy VS Code extension that converts pixels torem
automaticallylink -> px to rem
The rest is fantastic.
Hopefully, you'll find it helpful. 👍
1@danny101Posted about 1 month ago@AdrianoEscarabote thanks very much like u said im new to coding and web development
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord