Skip to content
Submitted 4 months ago

Testimonial-grid-flexbox

Stephen Raj M•220
@stephen3425
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Testimonials grid section
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I used flexbox next time will use CSS grid

What challenges did you encounter, and how did you overcome them?

The background image on the first card. First I used it in HTML, which either disappeared once the background color was applied or the text was overwritten. Later I switched to the style sheet and applied the image there that's how I resolved it.

Community feedback

  • Raptor0x1•210
    @Raptor0x1Posted 4 months ago

    It's not a good practice to build different projects on different branches. You could make different repos for each projects.

    Now coming to the code

    • I know you have said you will use grid next time but the project's name itself is saying to use grid. It would have been better if you had learned to use grid first and then started this project.

    • Don't use the id selector so casually. Id's have high specificity so they can easily override other tags and classes. So better don't use them unless it's very necessary.

    • In your CSS reset use box-sizing: border-box;. It's difficult to know what is happening as I am used to border-box. It makes much easier for other people for reviewing your code and time efficient too.

    • Use relative units (em, rem) instead of absolute units (px).

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord