Testimonial Grid _ Fe Mentor Challenge

Community feedback

• 

  Fran Extremera•210

  @franexmo81Posted about 1 year ago

  Nice submission, really accurate.

  I've just noticed some misbehaviour in the responsiveness:

  • The cards are not vertically centred on the screen.
  • The text overflow the cards on screens between 795 and 1250 px width
  • The violet card doesn't take the full width on screens narrower than 795 px

  I think that most of the above can be fixed by just doing:

  • Remove padding: 70px for main-wrapper
  • Replace height: 100vh with min-height: 100vh for main-wrapper
  • Remove grid-template-rows: 300px 300px for testimonial
  • Remove width: 300px for the violet card under 795 px width
  • Remove margin-top: 500px and margin-bottom: 500px for main-wrapper under 795 px width

  I hope the above helps you in your way to become a successful developer. Good luck!

  0