Design comparison
Solution retrospective
Feedback would be appreciated, made in about 45 mins, made it completely responsive.
Live site : https://testimonial-grid-fem.surge.sh/
Community feedback
- @correlucasPosted over 2 years ago
Hello Mubashir, congratulations for you solution, you've done a really good job here!
I took a look on your solution and there are really few things that you can do to improve, since your project is almost 100%.
Apply a correct padding to the card p that's under the class
.previous-experience
. If you look in the design files, you note that around the card there's a uniform padding between the elements, instead of applying a single padding in every element, you just add the correct padding a the div the hold all the elements inside the section. But this si a minor detail, you've done a really good work here. Congrats!You can also fix the accessibility issues to keep your code more semantic, take a look in the solution report panel.
I hope it helps you and happy coding!
Marked as helpful1@MubashirArifRandhawaPosted over 2 years ago@correlucas thanks for feedback, will apply the changes you mentioned and will reupload it again
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord