Design comparison
SolutionDesign
Solution retrospective
Can someone please check this and let me know if I should fit this in 100vh height or is this okay?
Community feedback
- @vanzasetiaPosted over 3 years ago
πHi Sandeep Gumaste! My name is Vanza!
I have some feedback on this solution:
- As you can see from the design comparison, the
background-color
for thebody
is different from the design, try to fix this. - Like Faris has said, using
min-height: 100vh
would be much better. If you want to see the problem with settingheight: 100vh
try to set width: 360px and height: 640px on your dev tool. - For the
quotation
, my recommendation is that usingbackground-image
andbackground-position
to position it.
.dan { background-image: url('/images/bg-pattern-quotation.svg'); background-repeat: no-repeat; background-position: top right; }
That's it! Hopefully this is helpful!
Marked as helpful1@SandeepGumastePosted over 3 years ago@vanzasetia Thankyou for the feedback. Fixing this asap :)
0 - As you can see from the design comparison, the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord