Design comparison
Solution retrospective
I've come across the var function in css and what it does. For future projects, I'll look to use it. After I completed this challenge, looking at Kevin Powell's grid video made me realise it would of been easier to have used grid-column rather than grid area. Other than that I feel my HTML mark-up is getting better.
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Add
min-height:100vh
in themain
to properly center the card.- Remove
top:100px
.
➨Give your
container
some width or more specificmax-width
because it become very large on larger screens.I hope you find this helpful.
Happy coding😄
1@SadorDevPosted over 1 year ago@NehalSahu8055 Thanks for your comment.
min-height:100
doesn't do anything other than reduce the bottom :|0 - Remove
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord