Testimonial Challenge Using FlexBox

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @SyedMIrtazaHyder, congratulations on completing this challenge!

  Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:

  1.You've missed the color for the background, in this case is background-color: #EDF2F8 and add it to the body.

  2.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.

  3.Prefer CLASS instead of ID to give style to your elements, choosing id is not a good idea because it’s a too specific selector and it's better to use it for forms or Javascript code. It is not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  To Dat•290

  @tltd0807Posted about 2 years ago

  hi IRTAZA HYDER’S. First of all, congratulation on your challenge, you did it very nice and i have learned from it a lot And here is my thought: -Grid will be easier for 2 dimensions layout you can watch here -The quotation you can set it as background with the position top left etc... link Also you can check my solution if you want And have a nice day 😁😁

  1