Design comparison
Community feedback
- @thomashertogPosted 4 months ago
Your HTML structure feels a bit weird because you made this challenge with flexbox. CSS Grid is far more suitable for this one. You may want to look into that. It would also make the
tes-grid-container
less confusing to use, since currently it's not a grid container but a flex container As for accessibility, you didn't include any semantics in your HTML. Jumped straight to heading level 4 (which is frowned upon). You wouldn't read a book that starts with1.1.1.1.
instead of1.
That said, this challenge doesn't have a visible single header (given you should only have one<h1>
on a page at any time)Styling done with ID-selectors is also a very bad practice. IDs do have a very high specificity and should be avoided if possible (you can easily replace them with a class here)
Keep improving, keep learning :)
Marked as helpful1@kendo-desuPosted 4 months ago@thomashertog First of all, thank you so much for your informative comment. This was actually my first challenge I tried and didn't rlly know what I was doing lol. Just started learning coding a month ago and I was following a YouTube video tutorial. Now that I have just learned about CSS Grid the day before, I will attempt this challenge again at a later date. I'll also have to read up more about the HTML semantics you mentioned!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord