Design comparison
Solution retrospective
There are some errors that I hadn't covered:
- On mobile, I didn't find any good units of measurement to adapt both cases (desktop/Mobile)
- Adjusting window size will not manage properly each testimonial
- Messages do not cover the right space on each testimonial If you have any suggestions, please comment below
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Giovanni, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every page should have one main landmark
<main>. So replace the div that wraps the whole content with<main>to improve the accessibility. click here2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
The rest is great!!
Hope it helps...👍
Marked as helpful0 - @correlucasPosted about 2 years ago
👾Ciao Giovanni, auguri per questo nuovo progetto!
Amazing solution as always! Here's some suggestions about html and semantic:
The html structure you’ve used here works, but if you want to make this even better, you can replace the
<div>you’ve used to keep the blocks and replace with some better html markup and semantic, for example, the main block can be wrapped with<main>and each testimonial card with<article>, then you can use a tag that not everyone knows, for the paragraph containing thequoteyou can replace the<p>with<blockquote>that is tag the describe exactly its content.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
--> To manage better the content inside the card its better you use a single padding for the div containing the card to manage the space around these text and add another padding for the vertical spacing, this way you control everything inside a single class.
✌️ I hope this helps you and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord