Testimonals Grid Section

Community feedback

• 

  Guilherme Magno•300

  @devMagnoPosted almost 4 years ago

  Hello! 👋 Good job on this challenge!

  The layout looks pretty good and it's responsive as well, good job! I loved the tablets and the mobile layout.

  I suggest removing the max-width: 1440px from the desktop media query and adding a max-width to the container instead, because it creates a weird single-column layout on bigger screens. Looking forward to your changes!

  Happy coding! 👊

  2

  ---

  

  Sukruti Konhar•30

  @sukrutikonharPosted almost 4 years ago

  @devMagno Thank you for the correction, I’ve made the appropriate changes. I ran the code correctly on my own setup (at the time of this writing) but did not proofread when writing the code for this project, so thank you for bringing this to my attention.

  0

  

  Guilherme Magno•300

  @devMagnoPosted almost 4 years ago

  You're welcome!

  The challenge looks really great now! Congrats ;)

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, nice job on this challenge, Sukruti Konhar! 👍

  Your solution looks good and responds very nicely! 👏

  The only thing I might suggest is to make sure that the grid doesn't stretch out too much on extra-large screens (e.g., above 1500px). Adding a max-width: 1440px or something similar to the grid container (as devMagno suggested) might help prevent that! 😉

  Keep coding (and happy coding, too)! 😁

  0
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Grate work @Sukruti. Same suggestion as @devMango. One more, please have a look for BEM naming conventions to make your class names more readable. Happy coding~ :)

  0