testimonails grid section with help of CSS Grids

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @Rajeshsingh127, congratulations on your new solution!

  I’ve some suggestions for you:

  1.IMPROVE YOUR WORKFLOW using VSCODE you can code your whole page using px and then in the end use a plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  2.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Rajesh Singh•280

  @Rajeshsingh127Posted about 2 years ago

  @correlucas thanks for the feedback. I'll keep the quote point in mind and use it.

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey, great job on this project!

  Some suggestions to improve you code:

  • To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  Sources:

  https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

  https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

  Happy Coding!

  1

  ---

  

  Rajesh Singh•280

  @Rajeshsingh127Posted about 2 years ago

  @vcarames thanks for the feedback. I'm learning the use case of them and this was helpful

  0