Design comparison
SolutionDesign
Solution retrospective
I just restant to learn HTML and CSS , so i decided to return from the root ... Pls read and tell me how i should've shorten my code and eventually if i made somes mistakes
Edit : I've made somes corrections thanks to the feedback . Thx
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @skyhall007!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful2@skyhall007Posted 9 months agothank you very much, i'll definitely apply your comment . @danielmrz-dev
0 - Using
- @Federico-SalernoPosted 9 months ago
Great job!! You solved the challenge neatly.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord