Template 3

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Josè, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • For add the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • use align-items: center flexbox property to the body to center the card vertically
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  0
• 

  Yacine Kahlerras•820

  @yacineKahlerrasPosted about 2 years ago

  Hey José good job on the challenge, i have one suggestion for better centering of the card you add this to the body body { min-height: 100vh; background-color: hsl(225, 100%, 94%); display: flex; justify-content: center; align-items: center; } and happy coding !

  Marked as helpful

  0