Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Task solution using CSS Flexbox

Ilia 80

@IliaIvashkevich

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please rate my first solution :)

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

  • If you replace <div class="container"> with the <main> tag, <div class="attribution"> with the <footer> tag, you can fix the accessibility issues.
  • You can also reach more information about HTML5 Semantic from Semantic HTML and Using Semantic HTML Tags Correctly.

Hope I am helpful. :)

0

@agun36

Posted

add some padding to your qr class

0

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • Your solution generates accessibility error reports due to non-semantic markup
  • So fix it by replacing the <div class="container"> with semantic element <main> to improve accessibility and organization of your page.
  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections

I hope you find it helpful ! 😄 Above all, the solution you submitted is great!

Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord