Design comparison
SolutionDesign
Solution retrospective
Please rate my first solution :)
Community feedback
- @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
- If you replace
<div class="container">
with the<main>
tag,<div class="attribution">
with the<footer>
tag, you can fix the accessibility issues. - You can also reach more information about HTML5 Semantic from Semantic HTML and Using Semantic HTML Tags Correctly.
Hope I am helpful. :)
0 - If you replace
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div class="container">
with semantic element<main>
to improve accessibility and organization of your page.
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
I hope you find it helpful ! 😄 Above all, the solution you submitted is great!
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord