Tarjeta utilizando HTML SASS - flexbox

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Greeting @eduardovaliente ,

  I have few suggestions regarding your solution:

  • To tackle the accessibility issues, you can use <footer > to wrap the attribution . HTML5 landmark elements are used to improve navigation .

  • Remove <br> , instead you can use padding or max-width.

  It's better not to use a header for class="card__subtitle " , you can use <p> .

  • using min-height: 100vh instaed of height: 100vh allows the body to to grow taller if the content outgrows the visible page.

  • width: 260pxan explicit width is not a good way . consider using max-width to card instead.

  • font-size: 62.5%; changing base html size. This has huge accessibility implications for those of us with different font size or zoom requirements.

  • You should use em and rem units .Both em and rem are flexible, Using px won't allow the user to control the font size based on their needs.

  Overall , your solution is good.Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Eduardo•20

  @eduardovalientePosted over 2 years ago

  @PhoenixDev22 Hola!! Muchas gracias por el feedback!! Desconocía muchas cosas de las que me sugirió! Lo pondré en práctica!

  Saludos!!! 🙌🙌

  1
• 

  Usama Ahmed•220

  @UsamaBinKashifPosted over 2 years ago

  Great one mate, I'll be happy if you look into my solution.

  Marked as helpful

  0

  ---

  

  Eduardo•20

  @eduardovalientePosted over 2 years ago

  @UsamaBinKashif Muchas gracias!! Claro, me paso por ahí con gusto! 🙌

  0